On Sun, 28 Mar 2021 23:13:22 GMT, Marius Hanl <github.com+66004280+mara...@openjdk.org> wrote:
> This PR fixes an issue, where table cells are not removed from the table row > when the corresponding table column got removed. This will lead to empty > "ghost" cells laying around in the table. > This bug only occurs, when a fixed cell size is set to the table. > > I also added 3 more tests beside the mandatory test, which tests my fix. > 1 alternative test, which tests the same with no fixed cell size set. > The other 2 tests are testing the same, but the table columns are set > invisible instead. > > -> Either the removal or setVisible(false) of a column should both do the > same: Remove the corresponding cells, so that there are no empty cells. > Therefore, the additional tests make sure, that the other use cases (still) > works and won't break in future (at least, without red tests ;)). > See also: TableRowSkinBase#updateCells(boolean) This pull request has now been integrated. Changeset: d808dd1e Author: Marius Hanl <mariush...@web.de> Committer: Ajit Ghaisas <aghai...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/d808dd1e Stats: 133 lines in 2 files changed: 126 ins; 1 del; 6 mod 8258663: Fixed size TableCells are not removed from sene graph when column is removed Reviewed-by: fastegal, aghaisas ------------- PR: https://git.openjdk.java.net/jfx/pull/444
