On Wed, 31 Mar 2021 14:04:42 GMT, Marius Hanl <github.com+66004280+mara...@openjdk.org> wrote:
>> This PR fixes an issue, where table cells are not removed from the table row >> when the corresponding table column got removed. This will lead to empty >> "ghost" cells laying around in the table. >> This bug only occurs, when a fixed cell size is set to the table. >> >> I also added 3 more tests beside the mandatory test, which tests my fix. >> 1 alternative test, which tests the same with no fixed cell size set. >> The other 2 tests are testing the same, but the table columns are set >> invisible instead. >> >> -> Either the removal or setVisible(false) of a column should both do the >> same: Remove the corresponding cells, so that there are no empty cells. >> Therefore, the additional tests make sure, that the other use cases (still) >> works and won't break in future (at least, without red tests ;)). >> See also: TableRowSkinBase#updateCells(boolean) > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > 8258663: Changes based of the code review looks good :) ------------- Marked as reviewed by fastegal (Committer). PR: https://git.openjdk.java.net/jfx/pull/444
