On Mon, 7 Nov 2022 19:46:08 GMT, Marius Hanl <[email protected]> wrote:
>> While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more >> layout container which do not snap their children correctly. >> >> The goal of this PR is to add snapping tests for all layout container. >> After that we can create issues for all broken layout container, fix them >> and comment in the corresponding line. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > 8296330: Added javadoc, made delta a constant, reordered working container > on top and renamed ContainerInstruction to ContainerCreator modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java line 155: > 153: // new ContainerCreator<>(StackPane::new), > 154: // new ContainerCreator<>(BorderPane::new), > 155: // new ContainerCreator<>(node -> { 1. should we create corresponding bug reports for the commented out containers? 2. should we also test other descendants of Pane (am I correct in guessing it's a Pane you call "container")? ------------- PR: https://git.openjdk.org/jfx/pull/936
