Re: RFR: 8296330: Tests: Add layout container snapping tests [v3]

[Marius Hanl]

On Tue, 8 Nov 2022 14:26:53 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8296330: Missed two :P
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
>  line 48:
> 
>> 46: /**
>> 47:  * Tests the snapping of all container inside {@link 
>> javafx.scene.layout}.
>> 48:  * Containers must always snap their width/height as well as there 
>> insets, otherwise the children may look blurry or
> 
> minor typo:  there insets -> their insets

thanks! fixed.

> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java
>  line 142:
> 
>> 140:     static Stream<ContainerCreator<?>> getContainerCreators() {
>> 141:         // TODO: Create issues and fix snapping for all commented out 
>> layout containers below.
>> 142:         // Note that the working layout container do not necessary use 
>> the optimized snappedXXXInsets() methods,
> 
> minor typo:
> 1. container -> containers
> 2. necessary -> necessarily

thanks! fixed.

-------------

PR: https://git.openjdk.org/jfx/pull/936