On Mon, 7 Nov 2022 19:55:59 GMT, Marius Hanl <[email protected]> wrote:
>> While checking https://bugs.openjdk.org/browse/JDK-8295078 I found much more >> layout container which do not snap their children correctly. >> >> The goal of this PR is to add snapping tests for all layout container. >> After that we can create issues for all broken layout container, fix them >> and comment in the corresponding line. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > 8296330: Missed two :P Test looks good. Provided with two minor typo corrections and a question. modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java line 48: > 46: /** > 47: * Tests the snapping of all container inside {@link javafx.scene.layout}. > 48: * Containers must always snap their width/height as well as there > insets, otherwise the children may look blurry or minor typo: there insets -> their insets modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java line 142: > 140: static Stream<ContainerCreator<?>> getContainerCreators() { > 141: // TODO: Create issues and fix snapping for all commented out > layout containers below. > 142: // Note that the working layout container do not necessary use > the optimized snappedXXXInsets() methods, minor typo: 1. container -> containers 2. necessary -> necessarily ------------- PR: https://git.openjdk.org/jfx/pull/936
