On Mon, 7 Nov 2022 19:51:04 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/SnappingTest.java >> line 137: >> >>> 135: >>> 136: assertEquals(widthHeight + snappedPaddingX, >>> container.prefWidth(-1), DELTA, className); >>> 137: assertEquals(widthHeight + snappedPaddingY, >>> container.prefHeight(-1), DELTA, className); >> >> sorry, should have specified in my previous comment - this constant is >> typically called EPSILON (a Greek letter denoting a very small number) > > While this is correct, the `assertEquals` method in JUnit calls this variable > `delta`, so I think both namings are understandable and fine Mathematically speaking, it is not a delta (change), it is a small quantity (epsilon). it's a minor nit pick, but in this context it should be an EPSILON. (There is one in TableUtil, but search in the code base and you'll find ~ 4K matches ------------- PR: https://git.openjdk.org/jfx/pull/936
