On Fri, 27 Oct 2023 16:39:33 GMT, Kevin Rushforth <[email protected]> wrote:
>> Sai Pradeep Dandem has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8185831: Changes to doc as per review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1959:
>
>> 1957: * If two nodes, lets say NodeA and NodeB have same style
>> class "myStyle" and NodeA has
>> 1958: * a pseudo state "myPseudo", then to find NodeA, the lookup
>> method can be used as follows:
>> 1959: * {@code scene.lookup(".myStyle:myPseudo");} or {@code
>> scene.lookup(":myPseudo");}. If no pseudo class is specified
>
> The sentence about what happens when no pseudo class is specified is true in
> general and not really part of this example. I recommend moving it before the
> two examples. And I think it could be worded more clearly.
>
>
> * If the lookup selector does not specify a pseudo class, the lookup will
> ignore pseudo class
> * states; it will return the first matching node even if it contains
> pseudo classes.
Or possibly even more clear:
* If the lookup selector does not specify a pseudo class, the lookup will
ignore pseudo class
* states; it will return the first matching node whether or not it contains
pseudo classes.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1245#discussion_r1375315319
