On Tue, 31 Oct 2023 21:55:20 GMT, Sai Pradeep Dandem <d...@openjdk.org> wrote:
>> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method of SimpleSelector.java. So checking for "applies()" alone is not >> sufficient in lookup() method. >> >> **Fix:** >> Included an extra check for the psuedo states to match. > > Sai Pradeep Dandem has updated the pull request incrementally with one > additional commit since the last revision: > > 8185831: Changes to doc as per review comments The updated docs look good. I also verified that the provided test fails without the fix and passes with the fix. NOTE: There is a Skara bug that causes the state of `/reviewers` command to be ignored. Do not integrate this until there are three (3) approving reviews. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1245#pullrequestreview-1708305784
