On Mon, 30 Oct 2023 01:16:58 GMT, Sai Pradeep Dandem <d...@openjdk.org> wrote:
>> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method of SimpleSelector.java. So checking for "applies()" alone is not >> sufficient in lookup() method. >> >> **Fix:** >> Included an extra check for the psuedo states to match. > > Sai Pradeep Dandem has updated the pull request incrementally with one > additional commit since the last revision: > > 8185831: Changes to doc as per review comments modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1956: > 1954: * it will return the first matching node whether or not it > contains pseudo classes. > 1955: * </p> > 1956: * <p> You don't need to surround a paragraph with `<p>...</p>`, a single `<p>` (without a corresponding `</p>`) between two paragraphs is sufficient. This reduces nesting, as it keeps the subsequent paragraphs on the same indentation. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1245#discussion_r1375678939
