On Wed, 15 Nov 2023 13:00:54 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> You're right, there's no implicit conversion from scoped enums to integers. >> While one could get very creative with C++, maybe just using an unscoped >> enum is easier. You might want to prefix the constants with `MT_` or >> something like that. > > The constants are referred as `MapType::BUMP` etc. I don't see what adding a > prefix will achieve. The `BUMP` symbol is not scoped to `MapType`; prefixing with `MapType::` is neither required, nor changes its meaning. The symbol exists in the global namespace in all compilation units that include the header. Adding a prefix to the symbol name may help to avoid name collisions in the future. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1281#discussion_r1401442104
