On Sat, 16 Nov 2024 19:43:07 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> I agree with that. It is often useful to have timestamp info in the builds >> during development. >> I know I'm a broken record on this topic, but if possible, it would be great >> if (parts of) this logic can be moved into a separate file in order to make >> the build.gradle smaller and more readable. I'm not insisting on this for >> this PR, but I think it is worth thinking about this whenever changes to >> build.gradle are made. > >> I know I'm a broken record on this topic, but if possible, it would be great >> if (parts of) this logic can be moved into a separate file in order to make >> the build.gradle smaller and more readable. > > Also at the risk of sounding like a broken record, > https://github.com/openjdk/jfx/pull/1232 has been waiting to start this > process for a while now and it's stuck waiting for explanations on how > publishing works, something only Oracle and Gluon do. If someone can help > Jendrik Johannes there then the ball will get rolling. I tried to split the > big build file into separate files for each module, but it's entangled with > the code in that PR. Completing that PR might also remove the need for the > JavaFX plugin. > > I know I'm a broken record on this topic, but if possible, it would be > > great if (parts of) this logic can be moved into a separate file in order > > to make the build.gradle smaller and more readable. > > Also at the risk of sounding like a broken record, #1232 has been waiting to > start this process for a while now and it's stuck waiting for explanations on > how publishing works, something only Oracle and Gluon do. If someone can help > Jendrik Johannes there then the ball will get rolling. I tried to split the > big build file into separate files for each module, but it's entangled with > the code in that PR. Completing that PR might also remove the need for the > JavaFX plugin. Fair remark. I just commented on the PR. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1845340131
