On Sun, 17 Nov 2024 09:06:00 GMT, Johan Vos <j...@openjdk.org> wrote:

>>> I know I'm a broken record on this topic, but if possible, it would be 
>>> great if (parts of) this logic can be moved into a separate file in order 
>>> to make the build.gradle smaller and more readable.
>> 
>> Also at the risk of sounding like a broken record, 
>> https://github.com/openjdk/jfx/pull/1232 has been waiting to start this 
>> process for a while now and it's stuck waiting for explanations on how 
>> publishing works, something only Oracle and Gluon do. If someone can help 
>> Jendrik Johannes there then the ball will get rolling. I tried to split the 
>> big build file into separate files for each module, but it's entangled with 
>> the code in that PR. Completing that PR might also remove the need for the 
>> JavaFX plugin.
>
>> > I know I'm a broken record on this topic, but if possible, it would be 
>> > great if (parts of) this logic can be moved into a separate file in order 
>> > to make the build.gradle smaller and more readable.
>> 
>> Also at the risk of sounding like a broken record, #1232 has been waiting to 
>> start this process for a while now and it's stuck waiting for explanations 
>> on how publishing works, something only Oracle and Gluon do. If someone can 
>> help Jendrik Johannes there then the ball will get rolling. I tried to split 
>> the big build file into separate files for each module, but it's entangled 
>> with the code in that PR. Completing that PR might also remove the need for 
>> the JavaFX plugin.
> 
> Fair remark. I just commented on the PR.

Added `relOpt = "-${buildTimestamp}" `

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1846451604

Reply via email to