On Tue, 18 Feb 2025 18:16:26 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Sure, but the downside is that everything gets more bloated for little >> benefit. Right now, these properties are accessed in derived classes without >> any checks, since they are final and non-null. In this case, I think ease of >> use is more important. > > ease of use for whom? > > bloated code: a few bytes in extra methods > bloated data: thousand of bytes added per instance > > Since we are adding properties to Window, it's probably ok because the number > of instances is relatively low (a real app won't have hundreds of windows). > Still, I would like to recommend investigating the alternative: the memory is > not an unlimited resource, and in my experience, it's worth thinking about it. Ease of use for JavaFX developers. Easily maintainable code is one of the most important aspects, miles ahead of chasing bytes and chasing nanoseconds. There's no tangible value in spending any considerable amount of time on thinking how to shave 150 bytes off of a window. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960480122
