On Tue, 18 Feb 2025 18:19:33 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> `HeaderButtonOverlay` inherits its node orientation from the scene, which is >> under the control of the application developer. On the other hand, >> `allowRtl` is under the control of JavaFX developers (that's us), specifying >> whether the selected header button implementation supports RTL layouts at >> all. Currently, all header button implementations do. >> >> The property is there to make all aspects of `HeaderButtonOverlay` >> styleable, so that future JavaFX developers can add other header button >> styles that may have fixed locations (i.e. don't move from one side to the >> other in RTL mode). > > should it have a different name then? `fixedPosition` or something like that? I've removed `allowRtl` completely. Let's entertain this problem when (and if) we decide to have system-provided header buttons that don't adjust for RTL mode. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1964663979