On Tue, 18 Feb 2025 18:26:22 GMT, Andy Goryachev <[email protected]> wrote:
>> This class is not API, so it doesn't matter here. However, it matters in
>> `HeaderBar.leftSystemInset/rightSystemInset`, which are both of type
>> `Dimension2D`. The system insets are not arbitrary rectangles, they are
>> always aligned with the top-left and top-right edges of the window. As such,
>> the only necessary information is their spatial extent, which is best
>> represented as a `Dimension2D`.
>> I'm not sure what you mean by asymmetrical padding. Can you elaborate?
>
> The word "inset" confused me. Could you use some other word here, if it is
> referring to a dimension? Like maybe explain where exactly these are used?
Are we talking about the specification of the system-reserved insets in
`HeaderBar`? Or do you suggest to link from `HeaderButtonMetrics` to
`HeaderBar`?
/**
* Describes the size of the left system-reserved inset, which is an area
reserved for the iconify, maximize,
* and close window buttons. If there are no window buttons on the left
side of the window, the returned area
* is an empty {@code Dimension2D}.
* <p>
* Note that the left system inset refers to the left side of the window,
independent of layout orientation.
*/
private final ReadOnlyObjectWrapper<Dimension2D> leftSystemInset =
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960518088
