On Tue, 18 Feb 2025 18:08:47 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minify button glyphs
>
> modules/javafx.graphics/src/main/resources/com/sun/glass/ui/gtk/WindowDecorationGnome.css
> line 126:
>
>> 124:
>> 125: .close-button > .glyph {
>> 126: -fx-shape: "m 8.1465,8.1465 a 0.5,0.5 0 0 0 0,0.707 L 11.293,12
>> 8.1465,15.1465 a 0.5,0.5 0 0 0 0,0.707 0.5,0.5 0 0 0 0.707,0 L 12,12.707 l
>> 3.1465,3.1465 a 0.5,0.5 0 0 0 0.707,0 0.5,0.5 0 0 0 0,-0.707 L 12.707,12
>> 15.8535,8.8535 a 0.5,0.5 0 0 0 0,-0.707 0.5,0.5 0 0 0 -0.707,0 L 12,11.293
>> 8.8535,8.1465 a 0.5,0.5 0 0 0 -0.707,0 z";
>
> Not sure I like the idea of using chatGPT.
> The changes look inconsistent - some are rounded to 3 places after the
> decimal, some to 4 (3 should be sufficient, I think even 2 will suffice)
There's no original work here that wasn't there before. I've checked the
rounding, it's correct and consistent. There are three decimal places only when
the fourth would be a zero. In any case, tweaking this further is a side-quest
with no value.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960475268
