On Tue, 22 Apr 2025 21:39:27 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 27 commits: >> >> - rm junit4 >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/8348736.rta.followup.2' into >> 8347359.rta.api.tests >> - ... and 17 more: https://git.openjdk.org/jfx/compare/703a9a90...0fb16fdc > > modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java > line 393: > >> 391: >> 392: @Test >> 393: public void getParagraphCount() { > > Maybe also assert that the paragraph count is initially null? 1 instead of null, there is always at least one paragraph in this model. > modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java > line 410: > >> 408: control.setModel(null); >> 409: // on second through, maybe this should return null >> 410: assertEquals(TextPos.ZERO, control.getParagraphEnd(0)); > > Are you keeping a list of such API questions? > > In this case, I would think that asking for a paragraph that is out of range > would throw IOOBE. What does control.getParagraph(N) do when N is out of > range? This method should behave similarly. good point, let me think about it. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2054990839 PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2054991912
