On Tue, 22 Apr 2025 21:37:38 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 27 commits: >> >> - rm junit4 >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/8348736.rta.followup.2' into >> 8347359.rta.api.tests >> - ... and 17 more: https://git.openjdk.org/jfx/compare/703a9a90...0fb16fdc > > modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java > line 307: > >> 305: control.copy(); >> 306: String s = Clipboard.getSystemClipboard().getString(); >> 307: assertEquals("ax", s); > > Suggestion: expand this to check various selection segments and boundary > conditions (e.g., test copying when the selection has a single character at > the beginning, missing, and end) as well as no selection (clipboard string > should be empty). Kevin, I am not entirely sure what you mean by `selection has a single character at the beginning, missing, and end` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2056668003
