On Wed, 23 Apr 2025 19:31:16 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Additional RichTextArea API tests. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 29 commits: > > - review comments > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - rm junit4 > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests > - ... and 19 more: https://git.openjdk.org/jfx/compare/d1fcca71...4f07d5f2 LGTM. I'll reapprove if you make further changes. modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java line 322: > 320: > 321: @Disabled("JDK-8355415") > 322: // TODO combine with copy() Minor: I might switch these two lines to keep all the annotations together. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1677#pullrequestreview-2788644840 PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2056846915
