On Tue, 22 Apr 2025 21:44:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 27 commits: >> >> - rm junit4 >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests >> - Merge remote-tracking branch 'origin/8348736.rta.followup.2' into >> 8347359.rta.api.tests >> - ... and 17 more: https://git.openjdk.org/jfx/compare/703a9a90...0fb16fdc > > modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java > line 444: > >> 442: >> 443: // @Test >> 444: // public void insertLineBreak() { > > Why is this commented out? A comment explaining why would be good. Or if > there is a functional bug that prevents it, uncomment it and skip it with > `@Disabled("JDK-8888888")`. created https://bugs.openjdk.org/browse/JDK-8355415 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2056679501