On Thu, 14 Aug 2025 07:26:04 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> We have Metal pipeline also now in macOS apart from OpenGL pipeline for >> accelerated hardware pipelines. >> >> Currently when Software pipeline is used we continue to use OpenGL(ES2) >> pipeline on glass side, which is the default hardware pipeline in macOS. If >> we want to switch to Metal pipeline as default hardware pipeline in prism, >> we should be able to use Metal pipeline in glass also when software pipeline >> is used. For this to happen we need to set some information when SWPipeline >> is getting initialized and pass that information to glass. >> >> This PR adds new flag `useMTLInGlass` in device details when SWPipeline is >> getting initialized and then passes it to glass code. When SWPipeline is >> used, based on this flag we will use appropriate hardware pipeline in glass. >> >> Patch is tested when useMTLInGlass is set to true/false and then using >> -Dprism.order=es2/mtl/sw and it picks proper GlassView/Layer. > > Jayathirth D V has updated the pull request incrementally with one additional > commit since the last revision: > > Pick default pipeline from PrismSettings modules/javafx.graphics/src/main/java/com/sun/prism/impl/PrismSettings.java line 209: > 207: // macDefaultPipeline flag will be used to determine whether to > 208: // use es2/mtl pipeline in glass, when sw pipeline is used in > prism > 209: macDefaultPipeline = macDefaultOrderArr[0]; Since this is a platform independent file, should we name this property in a generic way (even if it is only used for MacOS)? Something like `defaultPipeline?` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1868#discussion_r2278848018
