On Fri, 15 Aug 2025 11:41:13 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Pick default pipeline from PrismSettings > > modules/javafx.graphics/src/main/java/com/sun/prism/impl/PrismSettings.java > line 209: > >> 207: // macDefaultPipeline flag will be used to determine whether to >> 208: // use es2/mtl pipeline in glass, when sw pipeline is used in >> prism >> 209: macDefaultPipeline = macDefaultOrderArr[0]; > > Since this is a platform independent file, should we name this property in a > generic way (even if it is only used for MacOS)? > Something like `defaultPipeline?` Since `macDefaultOrderArr` is already mac-specific, I'm not sure how much this helps without also refactoring the rest of the logic. One possibility would be to move the if-then-else block up (before the check for the `"prism.order"` system property) and then assign the default pipeline after the tryOrder is assigned. I'll leave it up to Jay as whether he wants to do this. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1868#discussion_r2279218113
