On Mon, 18 Aug 2025 07:21:09 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> Since `macDefaultOrderArr` is already mac-specific, I'm not sure how much >> this helps without also refactoring the rest of the logic. >> >> One possibility would be to move the if-then-else block up (before the check >> for the `"prism.order"` system property) and then assign the default >> pipeline after the tryOrder is assigned. I'll leave it up to Jay as whether >> he wants to do this. > > if-then-else block requires "order" value to determine whether user is > explicitly setting any value. > > In case where user is explicitly setting `-Dprism.order=sw`, tryOrderArr will > have only "sw" value. So we need macOS prism default order values outside of > the if-then-else block. > > Since we need this mac specific default order values, i think its okay to > keep this mac specific flag. > I would like to keep the code as it is. Looks like we are talking about `if-then-else-if` block. That will work and it will help us to remove mac specific reference also. Will go ahead and make that change. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1868#discussion_r2281708417
