On Fri, 15 Aug 2025 15:19:42 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/prism/impl/PrismSettings.java >> line 209: >> >>> 207: // macDefaultPipeline flag will be used to determine whether to >>> 208: // use es2/mtl pipeline in glass, when sw pipeline is used in >>> prism >>> 209: macDefaultPipeline = macDefaultOrderArr[0]; >> >> Since this is a platform independent file, should we name this property in a >> generic way (even if it is only used for MacOS)? >> Something like `defaultPipeline?` > > Since `macDefaultOrderArr` is already mac-specific, I'm not sure how much > this helps without also refactoring the rest of the logic. > > One possibility would be to move the if-then-else block up (before the check > for the `"prism.order"` system property) and then assign the default pipeline > after the tryOrder is assigned. I'll leave it up to Jay as whether he wants > to do this. if-then-else block requires "order" value to determine whether use is explicitly setting any value. In case where user is explicitly setting `-Dprism.order=sw`, tryOrderArr will have only "sw" value. So we need macOS prism default order values outside of the if-then-else block. Since we need this mac specific default order values, i think its okay to keep this mac specific flag. I would like to keep the code as it is. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1868#discussion_r2281512492
