On Tue, 17 Feb 2026 18:03:56 GMT, Andy Goryachev <[email protected]> wrote:
>> build.gradle line 2785:
>>
>>> 2783: task initShaderDirs() {
>>> 2784: doLast {
>>> 2785: if (IS_WINDOWS) {
>>
>> I suggest we create the directories all the time (I don't see any harm in
>> having empty directories). Otherwise, we'd need to make Eclipse config
>> files platform specific, and I don't know how to do it.
>
> In fact, I would like a comment added here saying something like
>
> `do not introduce platform-specific logic here for the sake of third party
> tools (Eclipse)`
I guess the question I have then is - _why_ these files are a part of Eclipse
config files.
This is a build directory, which technically should contain only artifacts
related to building JavaFX. Why would HLSL compilation artifacts be needed at
all in Eclipse?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2071#discussion_r2821902490
