> On a given platform, the build generates prism and decora shader files for > all platforms. > Ideally it should generate only the platform specific shader files. > > Fix: > Generate only platform specific hardware shaders. > sw pipeline shaders must be generated for all platforms. > > But the hardware shaders, should be as: > 1. Mac platform : metal and es2 shaders > 2. Win platform: d3d shaders and if IS_INCLUDE_ES2 is true then es2 shaders > as well > 3. Linux : only es2 shaders > > Verification: > Verified that the shaders are generated as expected. > headul tests pass, apps launch correctly.
Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into opt-shader-creation - optimize creating shaders ------------- Changes: - all: https://git.openjdk.org/jfx/pull/2071/files - new: https://git.openjdk.org/jfx/pull/2071/files/9249bf0d..7cd12549 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=2071&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2071&range=00-01 Stats: 930 lines in 93 files changed: 598 ins; 109 del; 223 mod Patch: https://git.openjdk.org/jfx/pull/2071.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/2071/head:pull/2071 PR: https://git.openjdk.org/jfx/pull/2071
