On Mon, 16 Feb 2026 14:54:56 GMT, Ambarish Rapte <[email protected]> wrote:
>> On a given platform, the build generates prism and decora shader files for >> all platforms. >> Ideally it should generate only the platform specific shader files. >> >> Fix: >> Generate only platform specific hardware shaders. >> sw pipeline shaders must be generated for all platforms. >> >> But the hardware shaders, should be as: >> 1. Mac platform : metal and es2 shaders >> 2. Win platform: d3d shaders and if IS_INCLUDE_ES2 is true then es2 shaders >> as well >> 3. Linux : only es2 shaders >> >> Verification: >> Verified that the shaders are generated as expected. >> headul tests pass, apps launch correctly. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > avoid Decora and Prism dir, under javafx.graphics/build/hlsl LGTM, on both Windows and Linux only necessary files are created. Quick Ensemble run also works properly. ------------- Marked as reviewed by lkostyra (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2071#pullrequestreview-3814333632
