On Fri, 27 Feb 2026 13:40:06 GMT, John Hendrikx <[email protected]> wrote:
>> This fixes the regression in FlowPane introduced with JDK-8350149 -- the
>> calls have been adjusted in such a way that they follow the pre-25 JavaFX
>> behavior.
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove dead code.
AsciiArtParser is an interesting idea. Here some preliminary comments, I want
to play more with the new tool.
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AsciiArtParser.java
line 42:
> 40: * @param height the height of the region
> 41: */
> 42: public record Bounds(double x, double y, double width, double height) {
should the new code be formatted using 4 spaces per indent?
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AsciiArtParser.java
line 523:
> 521: return extent;
> 522: }
> 523: }
missing newline
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/LayoutAssertions.java
line 191:
> 189: return bounds;
> 190: }
> 191: }
missing newline
-------------
PR Review: https://git.openjdk.org/jfx/pull/2077#pullrequestreview-3867561512
PR Review Comment: https://git.openjdk.org/jfx/pull/2077#discussion_r2864893602
PR Review Comment: https://git.openjdk.org/jfx/pull/2077#discussion_r2864896704
PR Review Comment: https://git.openjdk.org/jfx/pull/2077#discussion_r2864899424
