On Fri, 27 Feb 2026 17:34:10 GMT, John Hendrikx <[email protected]> wrote:

>> This fixes the regression in FlowPane introduced with JDK-8350149 -- the 
>> calls have been adjusted in such a way that they follow the pre-25 JavaFX 
>> behavior.
>
> John Hendrikx has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add copyright headers

`AsciiArtParser` seems like a fun toot: the main benefit of using it is that it 
requires a graphical representation of the desired outcome, which might be nice.

This benefit is also a drawback: these diagrams are difficult to create and 
maintain.  Plus, we would need to maintain the parser itself as a part of 
javafx code base.

One possible alternative is to forgo the graphical aspect of it and simply 
describe the expected layout in form of a CSV-like table (or a github-like 
table), for example:


Location | WxH    | Margins
---------|--------|--------
         |10 x 5  | 
         |200 x 5 | 5 5 5 0


or something similar that is easy to generate and update if necessary.

What do you think?

-------------

PR Review: https://git.openjdk.org/jfx/pull/2077#pullrequestreview-3879213608

Reply via email to