On Fri, 27 Feb 2026 15:29:10 GMT, Andy Goryachev <[email protected]> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove dead code.
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AsciiArtParser.java
>  line 42:
> 
>> 40:    * @param height the height of the region
>> 41:    */
>> 42:   public record Bounds(double x, double y, double width, double height) {
> 
> should the new code be formatted using 4 spaces per indent?

Ah, oops, I copied this from my personal tools, I'll reformat it.

> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AsciiArtParser.java
>  line 523:
> 
>> 521:     return extent;
>> 522:   }
>> 523: }
> 
> missing newline

is that a problem?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2077#discussion_r2865401660
PR Review Comment: https://git.openjdk.org/jfx/pull/2077#discussion_r2865402701

Reply via email to