On Thu, 19 Mar 2026 21:47:51 GMT, Andy Goryachev <[email protected]> wrote:

>> chuckyschluz has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   move processContinguousRanges into the main function body
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java 
> line 188:
> 
>> 186:                 .collect(BitSet::new, BitSet::set, BitSet::or);
>> 187: 
>> 188:             for (int begin = added.nextSetBit(0); begin >= 0;) {
> 
> noticed these two blocks (here and L178) are identical except for the list 
> and the boolean flag.  would it make sense to extract these into a separate 
> function?

done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2100#discussion_r2962976505

Reply via email to