On Mon, 23 Mar 2026 18:36:13 GMT, Marius Hanl <[email protected]> wrote:
>> chuckyschluz has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add unit test > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java > line 6520: > >> 6518: sm1.selectRange(3, 7); >> 6519: sm2.selectIndices(3, 4, 5, 6); >> 6520: assertEquals(sm1.getSelectedIndices(), >> sm2.getSelectedIndices()); > > I guess we should also `assert` the selected indices here and below. > `assertEquals(List.of(3, 4, 5, 6), sm1.getSelectedIndices());` > > So we are 100% ccertain that the content is also what we expected (Right now > we only assert that `selectRange` and `selectIndices` works the same. But if > both would suffer from the very same bug, we would not catch that regression > here). +1 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2100#discussion_r2977074766
