On Tue, 24 Mar 2026 15:32:04 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make it final, improve docs
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/CellBehaviorBase.java
> line 176:
>
>> 174: latePress = isSelected();
>> 175: if (!latePress) {
>> 176: doSelect(e, e.getX(), e.getY(), e.getButton(),
>> e.getClickCount(),
>
> might as well pass only the event pointer
I tried to keep the diff minimal. But if you like, I can also change that, fine
for me
> modules/javafx.controls/src/main/java/javafx/scene/control/TableRow.java line
> 329:
>
>> 327: } else if (isEditing() && !rowMatch) {
>> 328: stopEdit();
>> 329: }
>
> I know it is in the original code, but we evaluate isEditing() twice.
> This might be slightly better:
>
> if (isEditing()) {
> if(!rowMatch) {
> stopEdit();
> }
> } else {
> if(rowMatch) {
> startEdit();
> }
> }
Yeah I agree. I would rather create a new ticket, as this is not the only thing
that is weird in cell code. Will have a deeper look soon and create a ticket to
improve that things.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r2983367231
PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r2983374145
