Re: RFR: 8089514: [TableView, TreeView, ListView, TreeTableView] Clicking outside of the edited cell, node, or entry should commit the value [v3]

[Marius Hanl]

On Tue, 24 Mar 2026 17:59:44 GMT, Marius Hanl <mh...@openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/TableRow.java 
>> line 329:
>> 
>>> 327:         } else if (isEditing() && !rowMatch) {
>>> 328:             stopEdit();
>>> 329:         }
>> 
>> I know it is in the original code, but we evaluate isEditing() twice.  
>> This might be slightly better:
>> 
>> if (isEditing()) {
>>     if(!rowMatch) {
>>         stopEdit();
>>     }
>> } else {
>>     if(rowMatch) {
>>         startEdit();
>>     }
>> }
>
> Yeah I agree. I would rather create a new ticket, as this is not the only 
> thing that is weird in cell code. Will have a deeper look soon and create a 
> ticket to improve that things.

I found some more oddities in the cell classes. Every cell has a slightly 
different implementation for almost everything (updateEditing, updateFocus, 
updateSelection, editing, ...). 

I want to create a Ticket and soon a PR to address this. Just want to check in 
if that is also something you would like to see?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r2998294422