On Fri, 27 Mar 2026 14:36:01 GMT, Andy Goryachev <[email protected]> wrote:
>> I found some more oddities in the cell classes. Every cell has a slightly >> different implementation for almost everything (updateEditing, updateFocus, >> updateSelection, editing, ...). >> >> I want to create a Ticket and soon a PR to address this. Just want to check >> in if that is also something you would like to see? > > Hard to say - I haven't looked at the cells specifically. The biggest > concern, I think, is the risk of regression, followed by the shortage of > bandwidth - do we want to spend time on small cleanup vs. huge issues (like > this PR). > > Having said that, I think it might be a good idea, especially if there is a > ton of bugs filed for a particular component or behavior. At the end, we > have to rely on our judgement to determine when it's worth doing or not doing > something. > > What are the major pain points you want to work on? I went into a rabbit hole yesterday. The 6 `IndexedCell` subclasses are so different. Every cell implemented `updateFocus`, `updateEditing`, `updateSelection` a bit different. E.g. when to clear it, when to return. Of course no tests. It's crazy how that made it into JavaFX. The best way would be to unify the behavior and write parameterized tests for all 6 cells and test the same methods. To be honest I don't know how to go from here. It would be nice to unify and have a stable reliable cell implementation for all cells. But as you said, it is a rather 'small' cleanup, although it will make our life easier in the future. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r3001549977
