On Thu, 26 Mar 2026 23:51:20 GMT, Marius Hanl <[email protected]> wrote:

>> Yeah I agree. I would rather create a new ticket, as this is not the only 
>> thing that is weird in cell code. Will have a deeper look soon and create a 
>> ticket to improve that things.
>
> I found some more oddities in the cell classes. Every cell has a slightly 
> different implementation for almost everything (updateEditing, updateFocus, 
> updateSelection, editing, ...). 
> 
> I want to create a Ticket and soon a PR to address this. Just want to check 
> in if that is also something you would like to see?

Hard to say - I haven't looked at the cells specifically.  The biggest concern, 
I think, is the risk of regression, followed by the shortage of bandwidth - do 
we want to spend time on small cleanup vs. huge issues (like this PR).

Having said that, I think it might be a good idea, especially if there is a ton 
of bugs filed for a particular component or behavior.  At the end, we have to 
rely on our judgement to determine when it's worth doing or not doing something.

What are the major pain points you want to work on?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r3001375017

Reply via email to