On Mon, 30 Mar 2026 21:28:41 GMT, Christopher Schnick <[email protected]> wrote:
>> This fixes a regression caused by the fix for >> https://bugs.openjdk.org/browse/JDK-8282290. The old if else block was >> broken by the other PR, which caused the calculation for the caret width to >> be never run. > > Christopher Schnick has updated the pull request incrementally with one > additional commit since the last revision: > > Clarify if else flow thank you for fixing the issue! sorry for a long delay. The fix seems to work on windows, even with fractional scale (tested at 125%, 150%, 175%, 225%). I also seems to work ok with the split caret, though I can't meaningfully test due to https://bugs.openjdk.org/browse/JDK-8242616 . Please issue `/template append` command and resolve the ai checkbox. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2128#pullrequestreview-4131768470 PR Comment: https://git.openjdk.org/jfx/pull/2128#issuecomment-4270902624 PR Comment: https://git.openjdk.org/jfx/pull/2128#issuecomment-4270924717
