On Wed, 25 Mar 2026 18:49:07 GMT, Christopher Schnick <[email protected]> wrote:
>> This fixes a regression caused by the fix for >> https://bugs.openjdk.org/browse/JDK-8282290. The old if else block was >> broken by the other PR, which caused the calculation for the caret width to >> be never run. > > Christopher Schnick has updated the pull request incrementally with two > additional commits since the last revision: > > - Adjust tests > - Adjust tests The caret shows on non-fractional display scales, which is already better than before. The user can test this. In the other cases where it still doesn't show, that is not due to this fix being wrong, but due to a completely separate issue of how the skin is implemented. That can be implemented in another, more large-scale issue. There are probably more issues caused by the skin not properly snapping values than just the caret not showing if you go looking for them at fractional scales. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2128#issuecomment-4138706407
