On Wed, 25 Mar 2026 17:53:26 GMT, Christopher Schnick <[email protected]> 
wrote:

> This fixes a regression caused by the fix for 
> https://bugs.openjdk.org/browse/JDK-8282290

I think the tests are wrong. I looked at the logic for the caret at 
https://github.com/openjdk/jfx/blob/d695b3162faa310f955fb4f17aa11637b1979178/modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java#L868
 and if I understand it correctly, if the caret is fully to the left, the text 
should be shifted by caretWidth / 2. The tests assume that the text is not 
shifted in this case, which I don't think is accurate. If that would be the 
case, then the caret would be invisible

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2128#issuecomment-4128911846

Reply via email to