On Mon, 2 Mar 2026 22:14:15 GMT, Michael Strauß <[email protected]> wrote:

>> The current implementation of `Renderer.getPeerInstance()` looks up mappings 
>> by concatenating strings to form a combined key:
>> 
>> peer = peerCache.get(name + "_" + unrollCount);
>> 
>> 
>> This can be improved by not using strings to store the combined key, but 
>> using a simple `PeerCacheKey` class instead.
>> The `Renderer` class then uses a single reusable `PeerCacheKey` object to 
>> look up mappings, making the lookup allocation-free.
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   review comment

LGTM.

Might makes sense to reevaluate the synchronization at one point, but that 
involves more code.

-------------

Marked as reviewed by mhanl (Committer).

PR Review: https://git.openjdk.org/jfx/pull/2091#pullrequestreview-4303674503

Reply via email to