On Mon, 2 Mar 2026 22:14:15 GMT, Michael Strauß <[email protected]> wrote:
>> The current implementation of `Renderer.getPeerInstance()` looks up mappings
>> by concatenating strings to form a combined key:
>>
>> peer = peerCache.get(name + "_" + unrollCount);
>>
>>
>> This can be improved by not using strings to store the combined key, but
>> using a simple `PeerCacheKey` class instead.
>> The `Renderer` class then uses a single reusable `PeerCacheKey` object to
>> look up mappings, making the lookup allocation-free.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comment
LGTM
modules/javafx.graphics/src/main/java/com/sun/scenario/effect/impl/Renderer.java
line 90:
> 88: private static final class PeerCacheKey {
> 89: String name;
> 90: int unrollCount;
Could this simply be `record PeerCacheKey(String name, int unrollCount) {}` ?
-------------
Marked as reviewed by jhendrikx (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/2091#pullrequestreview-3884490791
PR Review Comment: https://git.openjdk.org/jfx/pull/2091#discussion_r2879966175
