On Tue, 2 Jun 2026 14:37:01 GMT, Andy Goryachev <[email protected]> wrote:
>> About reprodution: Set the button cell to "With Icon" and select any value >> from the list. Then, change the converter. This should remove the graphic. >> There are probably more niche cases where the graphics gets removed on >> master. >> >> @Maran23 I looked through the code and it seems like the ComboBox realizes >> updates in the button cell by setting the value to null and then reselecting >> the value to force a call to updateItem(). This is correct as something >> happened that we can't observe, i.e. the converter changing. Touching >> anything on that side leads to unintended side effects like this one, so I >> chose to just keep it. This PR is only an effective one-line change now from >> the original code, much better than before. >> >> The bug with a selected contained null value not updating is because calling >> setItem(null) does not reset the cell as intended if null is already the >> selected value. That is why it uses setIndex() now > > @crschnick could you provide step-by-step instructions how to reproduce > please? I still don't see the issue. @andy-goryachev-oracle Set it to this: <img width="450" height="244" alt="image" src="https://github.com/user-attachments/assets/51a21216-cc72-442f-bdbe-09ee46aa3920"; /> Then, set the converter to anything else ------------- PR Comment: https://git.openjdk.org/jfx/pull/2179#issuecomment-4603530280
