On Mon, 1 Jun 2026 01:43:45 GMT, Christopher Schnick <[email protected]> 
wrote:

> This is a much simpler fix for JDK-8384806 which does not have any side 
> effects.
> 
> This restores the old code with only a one line change instead. For 
> reference, see 
> https://github.com/openjdk/jfx/commit/8d917ae738120e12ac12cd0957879b7c00e59b03.
>  We now fix the issue by clearing the cell with `buttonCell.updateIndex(-1);` 
> as using `buttonCell.setItem(null);` was causing the original issue when the 
> item was already null.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

thanks!  so the missing step is to have a non-editable combo box, then change 
the converter.

I've updated the JBS description to list the steps:

To reproduce using the monkey tester 
https://github.com/andy-goryachev-oracle/MonkeyTest :
- navigate to ComboBox page
- make sure the combo box editable is off
- set button cell to "With Icon", cell factory to null, converter to <default>
- select a value, observe the icon on the button
- change converter
expected: the icon remains
observed: the icon disappears

is this right?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2179#issuecomment-4603987148

Reply via email to