On Mon, 1 Jun 2026 01:43:45 GMT, Christopher Schnick <[email protected]> wrote:
> This is a much simpler fix for JDK-8384806 which does not have any side > effects. > > This restores the old code with only a one line change instead. For > reference, see > https://github.com/openjdk/jfx/commit/8d917ae738120e12ac12cd0957879b7c00e59b03. > We now fix the issue by clearing the cell with `buttonCell.updateIndex(-1);` > as using `buttonCell.setItem(null);` was causing the original issue when the > item was already null. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxListViewSkin.java line 370: > 368: // JDK-8127575 Show the ComboBox value even though it > doesn't > 369: // exist in the ComboBox items list (part two of fix) > 370: buttonCell.updateIndex(-1); a very quick comment, `buttonCell.updateIndex(-1); ` is common in both if and else block, may be move it before the if-else block, and use appropriate comments to explain the behavior ? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2179#discussion_r3349877825
