On Wed, 3 Jun 2026 15:39:47 GMT, Ambarish Rapte <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxListViewSkin.java > line 370: > >> 368: // JDK-8127575 Show the ComboBox value even though it >> doesn't >> 369: // exist in the ComboBox items list (part two of fix) >> 370: buttonCell.updateIndex(-1); > > a very quick comment, `buttonCell.updateIndex(-1); ` is common in both if > and else block, may be move it before the if-else block, and use appropriate > comments to explain the behavior ? Done ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2179#discussion_r3363777907
