On Thu, 4 Jun 2026 16:27:58 GMT, Marius Hanl <[email protected]> wrote:
>> This is a much simpler fix for JDK-8384806 which does not have any side >> effects. >> >> This restores the old code with only a one line change instead. For >> reference, see >> https://github.com/openjdk/jfx/commit/8d917ae738120e12ac12cd0957879b7c00e59b03. >> We now fix the issue by clearing the cell with >> `buttonCell.updateIndex(-1);` as using `buttonCell.setItem(null);` was >> causing the original issue when the item was already null. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java > line 525: > >> 523: >> 524: comboBox.setValue("ITEM1"); >> 525: assertEquals("ITEM1", ((Label) >> comboBox.getButtonCell().getGraphic()).getText()); > > `getDisplayNode()` Actually, the call to getDisplayNode() calls updateDisplayNode() in it, so to not skew the tests, the current version is better imo ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2179#discussion_r3363630090
