On Tue, 9 Jun 2026 13:51:14 GMT, Marius Hanl <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
> line 519:
>
>> 517: // They should not change the button cell graphic to null
>> 518: List<Runnable> methods = List.of(
>> 519: () -> comboBox.setPromptText("abc"),
>
> I think this is probably better as a new separate test. Now we are testing
> two different operations in one test. Even we end up copy pasting much of
> this test, I would like a second test only for the `setPromptText` much more
Alright I split it into multiple similar test methods
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2179#discussion_r3391591066
