On Thu, 2 Jul 2026 16:18:29 GMT, Petr Štechmüller <[email protected]> wrote:

>> ProxyBuilder is used by the FXML loader to instantiate classes whose 
>> constructors are annotated with `@NamedArg`. When such a class also exposes 
>> a read-only `Map` property (e.g. getProperties() — the same pattern used by 
>> `javafx.scene.Node`), setting child elements under that property in FXML 
>> caused incorrect behaviour or a runtime error.
>> 
>> **Root cause:** _getReadOnlyProperty()_ always returned an 
>> `ArrayListWrapper` regardless of the actual **getter** return type. When the 
>> getter returns a `Map`, an `ArrayListWrapper` is the wrong container and the 
>> entries are never transferred to the real map on the object.
>> 
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Petr Štechmüller has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Code cleanup

missing headers

modules/javafx.fxml/src/test/resources/test/javafx/fxml/class_with_default_list_property.fxml
 line 1:

> 1: <?xml version="1.0" encoding="UTF-8"?>

please make sure *all* new files have the copyright header

-------------

Changes requested by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2167#pullrequestreview-4639544429
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3531876685

Reply via email to