On Thu, 9 Jul 2026 08:27:03 GMT, Marius Hanl <[email protected]> wrote:
>> Petr Štechmüller has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix ProxyBuilder to correctly handle read-only Observable Integer/Float
>> array with @NamedArg
>
> modules/javafx.fxml/src/test/java/test/com/sun/javafx/fxml/builder/ProxyBuilderTest.java
> line 343:
>
>> 341: "containsKey must be true for the plain-List getter");
>> 342:
>> 343: @SuppressWarnings("unchecked")
>
> No need to keep those (in my opinion, those just clutter the code without any
> real benefit)
You are right. The `containsKey` method only creates a temporary contaier
which is also created by `pb.get` method.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3564410979
