On Sat, 11 Jul 2026 13:09:18 GMT, Marius Hanl <[email protected]> wrote:
>> Petr Štechmüller has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix ProxyBuilder to correctly handle read-only Observable Integer/Float >> array with @NamedArg > > modules/javafx.fxml/src/test/java/test/javafx/fxml/ClassWithDefaultPropertyTest.java > line 41: > >> 39: Assertions.assertEquals(1, >> classWithDefaultProperty.getItems().size()); >> 40: // Coma separated values are currently not supported in default >> list properties >> 41: // Assertions.assertEquals(3, >> classWithDefaultProperty.getItems().size()); > > maybe remove? I don't think this is something that can be supported without > breaking compatibility. Your call. I can remove tests for this case. I thought it would be great at least to have a test for this case since it was going through the code I was modifying. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3564432998
